Create sample app #17
Conversation
| source 'https://rubygems.org' | ||
| git_source(:github) { |repo| "https://github.com/#{repo}.git" } | ||
|
|
||
| ruby '3.0.1' |
There was a problem hiding this comment.
I don't agree to fix the ruby version in this sample app.
-- original text --
サンプルならいらない
There was a problem hiding this comment.
@katsyoshi I agree to remove the ruby version specify from "Gemfile". But, a rails app needs "a ruby version", right?
(Gemfileからrubyのversionを消すのは構わないですが、何らかのRubyのversion指定なしにRailsって起動できましたっけ？)
| @@ -0,0 +1,261 @@ | |||
| PATH | |||
There was a problem hiding this comment.
Why committed this file which is ignored?
-- original text --
ignore しているのに入れるの？
There was a problem hiding this comment.
Rails appのGemfile.lockのなので入れたいです、git ignoreしているというのは、mini_paperclipのtoplevel dirにあるGemfile.lockのことで、sample/Gemfile.lock は ! で無視しないようにしています。
| require "rails" | ||
| # Pick the frameworks you want: | ||
| require "active_model/railtie" | ||
| require "active_job/railtie" |
There was a problem hiding this comment.
[nits]
I seem that didn't use active_job.
-- original text --
使ってないのでは？
There was a problem hiding this comment.
使ってない確かに (rails newのoptionは全然つけていなかったので)
A working sample is important for a user.